[PATCH] D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode

jvikstrom abandoned this revision. jvikstrom added a comment. Resubmitted as 4 different CLs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63127/new/ https://reviews.llvm.org/D63127 ___ cfe-commits mai

[PATCH] D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:86 +.bind("ByAnyChar"), +expr(hasDescendant(cxxConstructExpr( + hasType(recordDecl(hasName("::absl::ByAnyChar"))), --

[PATCH] D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode

hokein added a comment. Thanks for investigating these, nice work! Some initial comments: - since your patch fixes four different check, I'd suggest to separate it (one patch per check) - there are some non-functional changes (code format), I'd avoid them in this patch (we could address them i

[PATCH] D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode

jvikstrom created this revision. jvikstrom added reviewers: hokein, gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. Fixes the checker for abseil to make tests pass in C++17 mode Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63127 Files: clang