[PATCH] D63335: [HIP] Add the interface deriving the stub name of device kernels.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363553: [HIP] Add the interface deriving the stub name of device kernels. (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D63335: [HIP] Add the interface deriving the stub name of device kernels.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63335/new/ https://reviews.llvm.org/D63335 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D63335: [HIP] Add the interface deriving the stub name of device kernels.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. This is a cleaner way to provide stub name tweaks. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:223 + // Ensure either we have different ABIs between host and device compilati

[PATCH] D63335: [HIP] Add the interface deriving the stub name of device kernels.

hliao added a comment. In D63335#1544428 , @tra wrote: > In D63335#1544324 , @hliao wrote: > > > > I think debugger does have sufficient information to deal with this and > > > that would be the right place to deal

[PATCH] D63335: [HIP] Add the interface deriving the stub name of device kernels.

tra added a comment. In D63335#1544324 , @hliao wrote: > > I think debugger does have sufficient information to deal with this and > > that would be the right place to deal with the issue. > > em, I did push the later as well, :(. OK, I will simplify the