[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

2019-10-04 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. In D63397#1696000 , @malaperle wrote: > "Extend our extension to support detecting these files as C++ files based on > the first > line (-*- C++ -*-), it will make clangd work on C++ standard headers > (e.g. iostream)." > > Th

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

2019-10-04 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. Herald added a subscriber: usaxena95. "Extend our extension to support detecting these files as C++ files based on the first line (-*- C++ -*-), it will make clangd work on C++ standard headers (e.g. iostream)." This is not in the standard right? I don't see this in MS

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

2019-06-17 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363554: [clangd] Detect C++ for extension-less source files in vscode extension (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

2019-06-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 204999. hokein marked 2 inline comments as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63397/new/ https://reviews.llvm.org/D63397 Files: clang-tools-extra/cla

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

2019-06-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Could you also update summary to include a link to documentation regarding `contributes.languages` ? Comment at: clang-tools-extra/clangd/clients/clangd-vscode/package.json:55 +"id": "cpp", +"firstLine": ".*-\\*-\\s*C\\+\\+\\s*

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

2019-06-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Extend our extension to support detecting these files as C++ files based on the first line (`-*- C++ -*-`), it will make clangd work