[PATCH] D63490: Script for generating AST JSON dump test cases

2019-06-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r363820; we'll look into integrating the script into lit as you suggested for a possible follow-up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63490/new/ https://reviews.llvm.org/D63490

[PATCH] D63490: Script for generating AST JSON dump test cases

2019-06-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! I think we can maybe make this a little more convenient to use. For the non-JSON `-ast-dump` format, I added `utils/make-ast-dump-check.sh` which can be used as (for example): $

[PATCH] D63490: Script for generating AST JSON dump test cases

2019-06-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. Trying to write or maintain test code for AST dumping of JSON information can be onerous due to small changes in the test requiring a large amount of line numbers or other information to be updated in the expected test