[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Causes crashes on Sema. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

This revision was automatically updated to reflect the committed changes. Closed by commit rL365036: [analyzer][CFG] Return the correct terminator condition (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

Szelethus requested review of this revision. Szelethus added a comment. This revision is now accepted and ready to land. Seems fine over here let's see what happens if I try to land it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

Szelethus planned changes to this revision. Szelethus added a comment. Something's off. `test/Analysis/edges-new.mm` fails, but I don't remember any test failures at home -- I'll investigate. Before this patch: F9448950: image.png After this patch: F9448940:

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

xazax.hun added a comment. This change will be really useful for the lifetime analysis as well! Thanks! I have one concern though. The analyzer is using linerarized (or threaded) CFGs with every subexpression being a separate entry in the basic blocks. Will your change give sensible answers

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538 ___ cfe-commits mailing list

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

Szelethus updated this revision to Diff 205909. Szelethus added a comment. Addressing reviewer feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp Index:

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

NoQ added a comment. I think this kinda makes sense, but also it looks like a risky change, because who knows how many times we have took the old behavior for granted. In particular, i'm slightly worried about this breaking the wonky logic of `ExprEngine::VisitLogicalExpr` (cf. D59857

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, a_sidorin, baloghadamsoftware, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. For