richard.barton.arm added a comment.
Herald added a subscriber: usaxena95.
Hi Peter
The overall approach seems good to me and matches how the driver is integrated
in the original flang project so not too many surprises. I left a few comments
mostly about the scope of the original patch. I
peterwaller-arm updated this revision to Diff 219666.
peterwaller-arm added a comment.
Fixed assertion message "Input output." => "Invalid output". The erroneous text
came was copied from:
hfinkel added inline comments.
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:73
+ } else {
+assert(Output.isNothing() && "Input output.");
+ }
Should this say "Invalid output"?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63607/new/
peterwaller-arm updated this revision to Diff 219538.
peterwaller-arm retitled this revision from "[clang][driver] Prototype
--driver-mode=fortran support for new flang" to "[clang][driver] Add basic
--driver-mode=fortran support for flang".
peterwaller-arm added a comment.
I updated this
