[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 282682. Tyker edited the summary of this revision. Tyker added a comment. Sorry for the delay In D63640#2151016 , @rsmith wrote: > Are we at a point where we can test this now? Yes we can use consteval to test it. so i

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

rsmith added a comment. Are we at a point where we can test this now? Perhaps by adding an assert in codegen that we always have an evaluated value for any `constexpr` variable that we emit? Comment at: clang/lib/Sema/SemaDecl.cpp:11883-11885 ExprResult Result = Act

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 236707. Tyker added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTImporter.h

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added a comment. now that the issue with uniqueness of expressions is solved. we should be able to keep going on that review @rsmith. https://reviews.llvm.org/D63960 should be i think close to completion. so maybe for testing i could use immediate invocation as a source for ConstantExpr i

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9635 +if (IsExpr) { + Base = APValue::LValueBase(ReadExpr(F), CallIndex, Version); + ElemTy = Base.get()->getType(); T

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker marked 10 inline comments as done. Tyker added a comment. update done tasks. Comment at: clang/lib/AST/APValue.cpp:599 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy)->

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

rsmith added inline comments. Comment at: clang/lib/AST/Expr.cpp:319 case RSK_None: return; case RSK_Int64: Can you use `llvm_unreachable` here? (Are there cases where we use `RSK_None` and then later find we actually have a value to store into the `C

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 222169. Tyker marked 3 inline comments as done. Tyker added a comment. made renamings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTCon

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:613 + /// in place as after importing/deserializating then. + void reserveVector(unsigned N) { +assert(isVector() && "Invalid accessor"); `ReserveVector` C

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/lib/AST/APValue.cpp:599 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy)->getElementType(); } aaron.ballma

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221568. Tyker marked 7 inline comments as done. Tyker added a comment. fixed most comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/A

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:618 } + const CXXRecordDecl **getMemberPointerPathPtr(); }; Tyker wrote: > aaron.ballman wrote: > > We're horribly inconsistent

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221384. Tyker marked 12 inline comments as done. Tyker retitled this revision from "[clang] Improve Serialization/Imporing of APValues" to "[clang] Improve Serialization/Imporing/Dumping of APValues". Tyker edited the summary of this revision. Tyker added a comm

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/include/clang/AST/APValue.h:618 } + const CXXRecordDecl **getMemberPointerPathPtr(); }; aaron.ballman wrote: > We're horribly inconsistent in this class, but because the other private > member functions go with