This revision was automatically updated to reflect the committed changes.
Closed by commit rL364474: [clang-scan-deps] Introduce the DependencyScanning
library with the (authored by arphaman, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
arphaman added a comment.
@aganea The FS `status` and most of file reads will be cached with the shared
FS. Hopefully I can put up a patch for it this week.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63681/new/
https://reviews.llvm.org/D63681
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:29
+/// sources either using a fast mode where the source files are minimized, or
+/// using the regular processing
aganea added a subscriber: rnk.
aganea added a comment.
A bit more detail on what we're seeing on our end (specs in the post above).
The 'Count' column represents the number of 1ms samples taken in that function.
The 'Weight' column is cumulated times for all cores, for a given process, in
ms.
aganea added a comment.
LGTM!
Some quick stats on our end (running Windows 10 on a Intel W-2135, 6-core, 3.7
GHz, NVMe SSD): on a large .SLN compiling approx. 16,000 .CPP files through 600
unity .CPPs and 23,000 .H files, out of **86 secs** spent in `ClangScanDeps`,
about **32 secs** are
arphaman created this revision.
arphaman added reviewers: Bigcheese, aganea.
Herald added subscribers: tschuett, dexonsmith, jkorous, mgorny.
Herald added a project: clang.
This patch extracts out the code that will powers the fast scanning worker into
a new file in a new DependencyScanning
