[PATCH] D63727: [analyzer] print() JSONify: Stable LocationContext IDs

2019-06-24 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso abandoned this revision. Charusso added a comment. In D63727#1556821 , @NoQ wrote: > I think i'd rather remove it entirely. I have seen a TODO in the differentiation of such indices, just why I made it. Okai. Repository: rC Clang CHANGES S

[PATCH] D63727: [analyzer] print() JSONify: Stable LocationContext IDs

2019-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I think i'd rather remove it entirely. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63727/new/ https://reviews.llvm.org/D63727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D63727: [analyzer] print() JSONify: Stable LocationContext IDs

2019-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In normal dumps i'd rather have it the old way because it's similar to how stack frames are displayed in the debugger. And in exploded graph rewriter we can always reverse our lists if we want; this number isn't really telling us much. Repository: rC Clang CHANGES SINC

[PATCH] D63727: [analyzer] print() JSONify: Stable LocationContext IDs

2019-06-24 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. - Repository: rC Clang https://reviews.llvm.org/D63727 Fi