[PATCH] D63894: [CXX] Exercise all paths through these tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL36: [CXX] Exercise all paths through these tests. (authored by probinson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson marked an inline comment as done. probinson added inline comments. Comment at: clang/test/SemaCXX/linkage2.cpp:3 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s -std=gnu++98 // RUN: %clang_cc1 -fsyntax-only -verify

[PATCH] D63894: [CXX] Exercise all paths through these tests

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/linkage2.cpp:3 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s -std=gnu++98 // RUN:

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson added a comment. In D63894#1576288 , @probinson wrote: > there is no reason to think those paths are tested elsewhere. Well that may be a tad strong. But I'm reluctant to remove them unless they are demonstrably tested elsewhere, and it's not

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson added a comment. In D63894#1574419 , @dblaikie wrote: > I would've assumed these conditionals were added by Sony folks for their > change in default dialect - that doesn't necessarily mean these tests are > needed upstream (the functionality

[PATCH] D63894: [CXX] Exercise all paths through these tests

dblaikie added a comment. I would've assumed these conditionals were added by Sony folks for their change in default dialect - that doesn't necessarily mean these tests are needed upstream (the functionality may be tested elsewhere) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson added a comment. Ping. This is pretty straightforward, the only question is whether we want to preserve these older-dialect tests or rip them out. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63894/new/ https://reviews.llvm.org/D63894

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson created this revision. probinson added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. These 3 tests have dialect-based conditionals, but weren't running Clang with enough different dialects to actually enable those conditional sections.