[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

This revision was automatically updated to reflect the committed changes. Closed by commit rL368086: [clang-scan-deps] Implementation of dependency scanner over minimized sources (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:76 +CachedFileSystemEntry +CachedFileSystemEntry::createDirectoryEntry(llvm::vfs::Status Stat) { +

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM, thank you! In D63907#1617417 , @arphaman wrote: > Just for reference, this patch still doesn't reuse the FileManager across > invocations in a

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added a comment. Just for reference, this patch still doesn't reuse the FileManager across invocations in a thread. We expect to get even better performance once we reuse it, but I'm going have to improve its API first. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:117 +std::mutex CacheLock; +llvm::StringMap> Cache; + }; aganea wrote: > Why not use a bump allocator here? (it would be

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 213664. arphaman marked 6 inline comments as done. arphaman added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files:

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added a comment. Thanks for the update Alex! Just a few more comments and we should be good to go: Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:117 +std::mutex CacheLock; +llvm::StringMap> Cache; + };

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:156 +/// this subclass. +class MinimizedVFSFile final : public llvm::vfs::File { +public: aganea wrote: > This makes only a short-lived objects, is

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 213511. arphaman marked 3 inline comments as done. arphaman added a comment. Fix comment typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files: clang/include/clang/Basic/FileManager.h

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:84 +DependencyScanningFilesystemSharedCache() { + NumShards = 8; + CacheShards = llvm::make_unique(NumShards); arphaman wrote: > aganea wrote:

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 212442. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files: clang/include/clang/Basic/FileManager.h clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:1 +//===- DependencyScanningFilesystem.h - clang-scan-deps fs ===---*- C++ -*-===// +// aganea wrote: > General comment for this file and

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 212435. arphaman marked 7 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files: clang/include/clang/Basic/FileManager.h

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added subscribers: sammccall, JDevlieghere. aganea added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:1 +//===- DependencyScanningFilesystem.h - clang-scan-deps fs ===---*- C++ -*-===// +//

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added a comment. I will take a look next week when I get back! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 211385. arphaman added a comment. Fix a bug for empty minimized files where null terminator lookup by the lexer was an out of bounds read CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files:

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman created this revision. arphaman added reviewers: Bigcheese, aganea. Herald added subscribers: tschuett, dexonsmith, jkorous, mgorny. Herald added a project: clang. This patch implements the fast dependency scanning mode in `clang-scan-deps`: the preprocessing is done on files that are