logan-5 added a comment.
*ping*
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64058/new/
https://reviews.llvm.org/D64058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good to me. (possible the check (for no default capture and no captures)
could be unified with the same check/language used for the implicit function
pointer conversion operator ("if
logan-5 added a comment.
I believe I need someone to commit it for me... brand new to all this and
unsure, frankly.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64058/new/
https://reviews.llvm.org/D64058
___
cfe-co
rsmith accepted this revision.
rsmith added a comment.
Do you have commit access or do you need someone to commit this for you?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64058/new/
https://reviews.llvm.org/D64058
___
logan-5 added a comment.
I had the exact same thought about factoring out this and the function pointer
conversion condition. I didn't bother, but I agree it could be a useful
function to have.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64058/new/
https://re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL365406: [cxx2a] P0624R2 fix: only lambdas with no
lambda-capture are default… (authored by dblaikie, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
logan-5 created this revision.
logan-5 added reviewers: rsmith, dblaikie.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is a fix for rG864949 which only disabled default construction and
assignment for lambdas with capture-defaults, where the C++2a draft disables
th
