[PATCH] D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc

2019-07-02 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Currently we do not differentiate lambda classes ba

[PATCH] D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc

2019-07-07 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin added a comment. Hi Gabor, it is a nice design question if source locations can participate in structural match or not. The comparison tells us that the same code written in different files is not structurally equivalent and I cannot agree with it. They can be not the same, but their

[PATCH] D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc

2019-08-16 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D64078#1572675 , @a_sidorin wrote: > Hi Gabor, > it is a nice design question if source locations can participate in > structural match or not. The comparison tells us that the same code written > in different files is not st