[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added a comment. Sounds good. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64083/new/ https://reviews.llvm.org/D64083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

Anastasia added a comment. In D64083#1583110 , @rjmccall wrote: > In D64083#1583109 , @rjmccall wrote: > > > Okay, so it sounds like *from the language perspective* all block pointers > > are actually pointers

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added a comment. In D64083#1583109 , @rjmccall wrote: > Okay, so it sounds like *from the language perspective* all block pointers > are actually pointers into `__generic`, and the thing with literals is just > an implementation detail that's

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added a comment. A qualifier "outside" the block-pointer type is telling you what address space the object which holds the block pointer is in, which is a completely different thing. Instead of `__global int (^block4)(void) = ^{ return 0; };`, you need to write `int (^__global

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

mantognini marked 2 inline comments as done. mantognini added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = Anastasia wrote: >

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

Anastasia added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > >

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = Anastasia wrote: > rjmccall wrote: > > Anastasia wrote: > > >

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

Anastasia added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > > All of

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = Anastasia wrote: > rjmccall wrote: > > All of this can be much

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

Anastasia added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = rjmccall wrote: > All of this can be much simpler: > > ``` > LangAS

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = All of this can be much simpler: ``` LangAS AddrSpaceL =

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL365500: [OpenCL][Sema] Improve address space support for blocks (authored by mantognini, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I would suggest to wait a day or two before committing just in case John has any feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

mantognini created this revision. mantognini added reviewers: rjmccall, Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. This patch ensures that the following code is compiled identically with -cl-std=CL2.0 and -fblocks -cl-std=c++. kernel void