steakhal added a comment.
This patch appears to introduce a bug in some source ranges.
Reported the regression at https://github.com/llvm/llvm-project/issues/71161.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64087/new/
https://reviews.llvm.org/D
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG256a0b298c68: [clang] Correct source locations for
instantiations of function templates. (authored by tahonermann).
Repository:
rG LLVM Github Mon
tahonermann updated this revision to Diff 556970.
tahonermann added a comment.
Addressed review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64087/new/
https://reviews.llvm.org/D64087
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sem
cor3ntin accepted this revision.
cor3ntin added a comment.
1 nit but still LGTM
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:4993
- // Copy the inner loc start from the pattern.
+ // Copy source locations from the pattern.
+ Function->setLocation(PatternDecl-
tahonermann added a comment.
@cor3ntin, any concerns or suggestions per my recent updates? I'll plan to land
this in the next couple of days otherwise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64087/new/
https://reviews.llvm.org/D64087
_
tahonermann updated this revision to Diff 556604.
tahonermann added a comment.
Moved the added release note to the correct section.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64087/new/
https://reviews.llvm.org/D64087
Files:
clang/docs/Releas
tahonermann added a comment.
@Endill, thank you for the reminder about this old patch!
@cor3ntin, I added an additional test and updated a few other recently
(relative to the original patch!) added tests. Would you be so kind as to give
this another quick review?
Repository:
rG LLVM Github
tahonermann updated this revision to Diff 556592.
tahonermann edited the summary of this revision.
tahonermann added a comment.
Rebased patch uploaded. This retains the same code change, but includes
additional test updates for tests added since the first patch was submitted, as
well as an addit
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
LGTM (assuming rebase goes well)
@tahonermann ping folks in the future, and apologies for taking... 4 years!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D6
Endill added a comment.
@tahonermann Do you mind rebasing this on top of trunk if it's necessary?
Might be a good idea to resubmit this as PR.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64087/new/
https://reviews.llvm.org/D64087
__
tahonermann added a comment.
See PR25683 (https://bugs.llvm.org/show_bug.cgi?id=25683) for more details.
The patch posted here differs slightly from what is posted in the PR;
`getLocation()` is called instead of `getBeginLoc()` since the latter may
return a customized begin location.
I believ
tahonermann created this revision.
tahonermann added a reviewer: rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes PR25683 (https://bugs.llvm.org/show_bug.cgi?id=25683)
This change completes adjustments of source locations for FunctionDecl
definitions correspond
12 matches
Mail list logo