[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixed SelectionTree bug for macros - Fixed SelectionTree claimRange for macros and template instantiat

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 208387. SureYeaah added a comment. Removed debugging code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Selection.cpp clang-tool

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 208389. SureYeaah added a comment. Removed extra includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Selection.cpp clang-tool

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:247 return SelectionTree::Unselected; -// getTopMacroCallerLoc() allows selection of constructs in macro args. e.g: +// getFileRange() allows selecting macro arg expansions //

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209199. SureYeaah marked 6 inline comments as done. SureYeaah added a comment. Changed claimRange to use toHalfOpenFileRange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209229. SureYeaah added a comment. Changed a breaking test in ExtractVariable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Select

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209506. SureYeaah added a comment. Added a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-ext

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

sammccall added a comment. Just doc nits I think. This eliminates a semi-fast path (that uses approximate token matching to avoid running the lexer in claimRange sometimes) but I think we can live without it. Comment at: clang-tools-extra/clangd/Selection.cpp:242 // This i

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 210783. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Updated comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-e

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:399 + // FIXME: SelectionTree needs to be fixed for macros + /*{R"cpp(#define LOOP(x

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL366566: [Clangd] Fixed SelectionTree bug for macros (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review