[PATCH] D64458: add -fthinlto-index= option to clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rL366146: add -fthinlto-index= option to clang-cl (authored by inglorion, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D64458: add -fthinlto-index= option to clang-cl

pcc added a comment. I think it's a little unfortunate that we're continuing to go down the road of letting users pass more flags to the ThinLTO backend action, but I won't stand in the way here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64458

[PATCH] D64458: add -fthinlto-index= option to clang-cl

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm too, since now this is just whitelisting a clang flag for clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64458/new/ https://reviews.llvm

[PATCH] D64458: add -fthinlto-index= option to clang-cl

inglorion updated this revision to Diff 209954. inglorion added a comment. Simplified after rebasing on top of r366127. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64458/new/ https://reviews.llvm.org/D64458 Files: clang/include/clang/Driver/Op

[PATCH] D64458: add -fthinlto-index= option to clang-cl

tejohnson added a comment. LGTM, but please wait for @pcc to make sure he is satisfied. I think it would be good to port the file type deduction to clang (possibly as a follow on), to make these consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D64458: add -fthinlto-index= option to clang-cl

inglorion added a comment. > Do we really need to support clang-cl syntax here? Can't the user of > -fthinlto-index= use the regular clang driver? We could, of course, require using the clang driver for this feature. But I would argue that clang-cl exists to make it easy for projects that use

[PATCH] D64458: add -fthinlto-index= option to clang-cl

rnk added a comment. In D64458#1577435 , @pcc wrote: > Do we really need to support clang-cl syntax here? Can't the user of > -fthinlto-index= use the regular clang driver? I think it depends on how many compiler flags we have to pass to backend compil

[PATCH] D64458: add -fthinlto-index= option to clang-cl

pcc added a comment. Do we really need to support clang-cl syntax here? Can't the user of -fthinlto-index= use the regular clang driver? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64458/new/ https://reviews.llvm.org/D64458 __

[PATCH] D64458: add -fthinlto-index= option to clang-cl

inglorion added a comment. This is similar to r254927 for the clang driver, and reuses the tests from that commit for the backend part. On the frontend, it differs in that clang-cl does not support -x (per the comment in clang/lib/Driver/Driver.cpp line 2068: "// No driver mode exposes -x and /

[PATCH] D64458: add -fthinlto-index= option to clang-cl

inglorion created this revision. inglorion added reviewers: tejohnson, pcc, rnk. Herald added subscribers: arphaman, dexonsmith, steven_wu, mehdi_amini. Herald added a project: clang. This adds a -fthinlto-index= option to clang-cl, which allows it to be used to drive ThinLTO backend passes. This