[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske added a comment. Rename of constants: https://reviews.llvm.org/D67174 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 ___ cfe-commits mailing list

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370903: [ASTImporter] Added visibility context check for TypedefNameDecl. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske updated this revision to Diff 218610. balazske added a comment. - Added comment about repeated enums in C99. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterVisibilityTest.cpp:343 +::testing::Values( +std::make_tuple(ExternTypedef, ExternTypedef, ExpectLink), +std::make_tuple(ExternTypedef, AnonTypedef, ExpectNotLink),

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

shafik added a comment. In D64480#1654354 , @balazske wrote: > In D64480#1653629 , @shafik wrote: > > > It is worth noting that: > > > > typedef int T; > > typedef int T; > > > > > > is not valid C99 see

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske marked 3 inline comments as done. balazske added a comment. In D64480#1653629 , @shafik wrote: > It is worth noting that: > > typedef int T; > typedef int T; > > > is not valid C99 see godbolt Should we handle

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske updated this revision to Diff 218311. balazske added a comment. - Removed unneeded structs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske updated this revision to Diff 218310. balazske added a comment. Improved the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

shafik added a comment. It is worth noting that: typedef int T; typedef int T; is not valid C99 see godbolt Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

shafik added inline comments. Comment at: lib/AST/ASTImporter.cpp:949 +return Importer.GetFromTU(Found) == From->getTranslationUnitDecl(); + return From->isInAnonymousNamespace() == Found->isInAnonymousNamespace(); +} I am not sure what case this covers?

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. balazske added a parent revision: D64477: [ASTImporter] Using