This revision was automatically updated to reflect the committed changes.
Closed by commit rL365631: [clangd] Add a flag to clangdServer rename function
to control whether we want… (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
hokein updated this revision to Diff 208940.
hokein marked an inline comment as done.
hokein added a comment.
Address review comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64481/new/
https://reviews.llvm.org/D64481
Files:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a small NIT.
Was also thinking about adding a test for this, but the amount of work required
to do so seems to outweigh the usefulness. Therefore seems ok to land
hokein created this revision.
hokein added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
This would allow clangd embedders to use the ClangdServer::rename for other
purposes (highlighting all the occurrences of
