This revision was automatically updated to reflect the committed changes.
Closed by commit rL366143: [OpenCL] Make TableGen'd builtin tables and
helper functions static (authored by tstellar, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to c
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64608/new/
https://reviews.llvm.org/D64608
Pierre added a comment.
Hello Tom,
Thank you for adding me, the changes seem correct to me.
There is a new version of the tablegen builtin functions that makes these
tables static/const. It still needs some work, so I thing it's relevant to make
this change in the meantime :
https://reviews.llv
tstellar created this revision.
tstellar added reviewers: Pierre, Anastasia.
Herald added a subscriber: yaxunl.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D64608
Files:
clang/lib/Sema/SemaLookup.cpp
clang/utils/TableGen/ClangOpenCLBuiltinEmi
