[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. I created D66700 with an improved warning message. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/ https://reviews.llvm.org/D64696 ___ cfe-commits

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

davezarzycki added a comment. I don't think anybody is running doxygen over the Swift source right now, so I'll just escape the @ sign. That being said, can we improve this diagnostic? "command does not have an argument" is confusing when a given command does have an argument, just a malformed

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. Unfortunately I'm not able to quickly find the Doxygen output of Swift online. When I process: `A limited variant of \c @objc that's used for classes with generic ancestry.` with Doxygen I get: `A limited variant of that's used for classes with generic ancestry.` Since

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

davezarzycki added a comment. From the Swift language source (http://github.com/apple/swift): include/swift/AST/Attr.h:/// A limited variant of \c @objc that's used for classes with generic ancestry. include/swift/AST/Decl.h: /// \c @usableFromInline attribute are treated as public. This is

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. I think it should warn; according to the documentation [1] `\c` expects a word. Testing with Doxygen indeed gives a warning. Can you post the real comment where this occurs? [1] http://www.doxygen.nl/manual/commands.html#cmdc Repository: rL LLVM CHANGES SINCE

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

davezarzycki added a comment. Hello – This change seems to have exposed a bug in -Wdocumentation argument parsing. For example, this warns when it shouldn't(?): /// \c @foobar Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL367809: Adds a warning when an inline Doxygen comment has no argument (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. Thanks for the review. I don't have commit access. So yes please commit the patch for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/ https://reviews.llvm.org/D64696 ___ cfe-commits mailing list

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thank you! Do you have commit access or would you like me to commit this patch for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante updated this revision to Diff 211340. Mordante added a comment. Addresses @gribozavr comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/ https://reviews.llvm.org/D64696 Files: clang/include/clang/Basic/DiagnosticCommentKinds.td

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante marked 2 inline comments as done. Mordante added a comment. All inline commands defined in include/clang/AST/CommentCommands.td require an argument. The escape commands, like \&, are handled in the switch starting at lib/AST/CommentLexer.cpp:366. They are stored as Text and not as an

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

gribozavr added a comment. Is it true that all inline commands require an argument? For example, "\&" does not. Comment at: clang/test/Sema/warn-documentation.cpp:1030 +// The inline comments expect a string after the command. +// expected-warning@+1 {{'\a' command does not

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante created this revision. Mordante added reviewers: gribozavr, rsmith. Mordante added a project: clang. It warns for for comments like /** \pre \em */ where \em has no argument This warning is enabled with the -Wdocumentation option. Repository: rG LLVM Github Monorepo