rsmith added a comment.
Can you reduce this patch to only the `&&` within `||` and `&` within `|`
changes? I think we have reasonable consensus that that should not be enabled
by default, so let's land that part now. If you want to continue discussing
`-Wshift-op-parentheses` after that, we can
MaskRay marked an inline comment as done.
MaskRay added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656
def warn_addition_in_bitshift : Warning<
"operator '%0' has lower precedence than '%1'; "
+ "'%1' will be evaluated first">, InGroup, Def
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656
def warn_addition_in_bitshift : Warning<
"operator '%0' has lower precedence than '%1'; "
+ "'%1' will be evaluated first">, InGroup, DefaultIgnore;
MaskRay
MaskRay marked an inline comment as done.
MaskRay added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656
def warn_addition_in_bitshift : Warning<
"operator '%0' has lower precedence than '%1'; "
+ "'%1' will be evaluated first">, InGroup, Def
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656
def warn_addition_in_bitshift : Warning<
"operator '%0' has lower precedence than '%1'; "
+ "'%1' will be evaluated first">, InGroup, DefaultIgnore;
MaskRay
MaskRay marked an inline comment as done.
MaskRay added a comment.
Ping :)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65192/new/
https://reviews.llvm.org/D65192
___
cfe-commits mailing list
cfe-commits@lists.llvm.
MaskRay marked 3 inline comments as done.
MaskRay added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5647-5650
def warn_overloaded_shift_in_comparison :Warning<
"overloaded operator %select{>>|<<}0 has higher precedence than "
"comparison operato
MaskRay updated this revision to Diff 212265.
MaskRay edited the summary of this revision.
MaskRay added a comment.
keep -Woverloaded-shift-op-parentheses enabled by default
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65192/new/
https://reviews.llvm.org/D65192
MaskRay marked an inline comment as done.
MaskRay added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656
def warn_addition_in_bitshift : Warning<
"operator '%0' has lower precedence than '%1'; "
+ "'%1' will be evaluated first">, InGroup, Def
rsmith added a comment.
For the `&&` vs `||` and `&` vs `|` warnings, it seems extremely implausible to
me that they meet the "few or no false-positives" criterion for an
enabled-by-default warning. Even assuming that people don't know the relative
precedences of those operators, we'd expect a
jyknight added a comment.
I'm not sure the history behind why these were added as default-on
warningsthey don't really seem appropriate as default warnings to me,
either.
But I think someone else probably ought to approve the change.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
htt
MaskRay updated this revision to Diff 211425.
MaskRay edited the summary of this revision.
MaskRay added a comment.
Delete -Wmost from the hierarchy. It doesn't belong there
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65192/new/
https://reviews.llvm.org/D65192
MaskRay created this revision.
MaskRay added reviewers: akyrtzi, jyknight, rtrieu, rsmith.
Herald added subscribers: cfe-commits, dexonsmith.
Herald added a project: clang.
The -Wparentheses warnings are enabled by default in clang but they are under
-Wall in gcc (gcc/c-family/c.opt). Many of the
13 matches
Mail list logo
