[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia created this revision. Anastasia added reviewers: rjmccall, rsmith, mantognini. Herald added subscribers: ebevhan, yaxunl. I am recreating the review from https://reviews.llvm.org/D59426 that seem to get lost somehow. The idea is to be able to allow creating vector literals from other

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

rjmccall added a comment. Wait, plain C++? Do we currently allow this syntax outside of OpenCL? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65286 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia added a comment. In D65286#1601404 , @rjmccall wrote: > Wait, plain C++? Do we currently allow this syntax outside of OpenCL? Ok I looked into this again and it seems apparently vector initialization and literals in C++ have different syntax.

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

rjmccall added a comment. Okay. It seems reasonable to me to allow OpenCL vector initialization syntax in OpenCL C++, since we're treating OpenCL C++ as an ObjC++-like merge of the language extensions, but we shouldn't go further than that and start changing behavior in the non-OpenCL language

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

mantognini added a comment. In `vector_literals_nested.cl`, we have tests for (global) constants. Do you think it would be worth testing those as well in C++ mode? Maybe the two files (`vector_literals_nested.cl` and `vector_literals_valid.cl`) should also be merged as most of their content see

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia updated this revision to Diff 212350. Anastasia added a comment. - Merged test/CodeGenOpenCL/vector_literals_nested.cl into test/CodeGenOpenCL/vector_literals_valid.cl - Added negative test case for C++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia added a comment. In D65286#1606071 , @mantognini wrote: > In `vector_literals_nested.cl`, we have tests for (global) constants. Do you > think it would be worth testing those as well in C++ mode? Maybe the two > files (`vector_literals_nested.c

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia updated this revision to Diff 212358. Anastasia added a comment. - Removed another duplicate file and added testing of constant program scope initializers into vector_literals_nested.cl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65286

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65286 ___ cfe-co

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

rjmccall added a comment. In D65286#1606441 , @Anastasia wrote: > In D65286#1606071 , @mantognini > wrote: > > > In `vector_literals_nested.cl`, we have tests for (global) constants. Do > > you think it would be w

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rL367675: [OpenCL] Allow OpenCL C style vector initialization in C++ (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

ebrevnov added a comment. Please be aware about build bot failure (http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/2185) most likely caused by this change. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia added a comment. In D65286#1614239 , @ebrevnov wrote: > Please be aware about build bot failure > (http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/2185) > most likely caused by this change. Thanks! I believe it is now fix