This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL369585: NFCI: Simplify SourceManager::translateFile by
removing code path that should… (authored by arphaman, committed by
arphaman added a comment.
Ping. I will commit it this week if there are no objections.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65481/new/
https://reviews.llvm.org/D65481
___
cfe-commits mailing l
arphaman created this revision.
arphaman added reviewers: rsmith, bruno, Bigcheese.
Herald added subscribers: dexonsmith, jkorous.
Herald added a project: clang.
I noticed that `SourceManager::translateFile` has code that doesn't really make
sense. In particular, if it fails to find a `FileID` by