[PATCH] D65483: [clang-doc] Add link to source code in file definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rL368460: [clang-format] Add link to source code in file definitions (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 ___ cfe-commits mailing list c

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 214004. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeW

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 214000. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Add comments. Move definition of ClangDocContext constructor to .cpp file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.ll

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:385 +SourceRoot(SourceRoot), UserStylesheets(UserStylesheets), +JsScripts(JsScripts) { +if (!RepositoryUrl.empty()) { Move to .cpp file (now that it h

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213776. DiegoAstiazaran added a comment. Remove unnecessary type casting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/cl

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/docs/clang-doc.rst:93 +--public- Document only public declarations. +--repository= - + URL of repository that hosts code. julie

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213772. DiegoAstiazaran marked 7 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Add comments. Change name of flag; `root-directory` -> `--source-root` Moved fixing of repository link to Cl

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); + Node->Children.emplace_back(llvm::make_unique("

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran added a subscriber: phosek. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); +

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213169. DiegoAstiazaran marked 7 inline comments as done. DiegoAstiazaran added a comment. Change http to https as the default fix to the repository link. Add new flags to clang-doc documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

jakehehrlich added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:376 + LocNumberNode->Attributes.try_emplace( + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode));

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

Eugene.Zelenko added a comment. It'll be reasonable to mention new command-line arguments in documentation and Release Notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 ___ cfe-commits mailing