Bigcheese added a comment.
This looks like a good simplification, but I think `call_once` could be
simplified more.
Comment at: llvm/cmake/modules/CheckAtomic.cmake:46
+ if (NOT HAVE_ATOMICS_WITH_LIB)
+ message(FATAL_ERROR "Host compiler must support atomic!")
jfb updated this revision to Diff 212479.
jfb added a comment.
- Remove from cmake
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65493/new/
https://reviews.llvm.org/D65493
Files:
clang-tools-extra/clangd/CMakeLists.txt
jfb created this revision.
jfb added reviewers: rnk, Bigcheese, __simt__.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, kadircet,
arphaman, dexonsmith, jkorous, hiraditya, mgorny.
Herald added projects: clang, LLDB, LLVM.
Some of the cmake checks are obsolete and make
