[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

This revision was automatically updated to reflect the committed changes. Closed by commit rL369574: [analyzer] Mention whether an event is about a condition in a bug report part 1 (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus added a comment. In D65575#1638430 , @xazax.hun wrote: > LGTM! I think the UIs could do better displaying this info in the future but > this is not your job :) https://github.com/Ericsson/codechecker/pull/2279 CodeChecker now indents

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

xazax.hun added a comment. LGTM! I think the UIs could do better displaying this info in the future but this is not your job :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 ___ cfe-commits

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

xazax.hun accepted this revision. xazax.hun added a comment. *actually accepting* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus added a comment. Hmm-hmm, I kinda like the comma, but would happily concede on this. Its been a while since my english exam :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 ___

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! I also suspect we don't need the comma. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus updated this revision to Diff 216273. Szelethus added a comment. - Change the condition postfix as discussed - `expected-note{{...}}` -> `expected-note-re^}}...{{$` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 Files:

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

NoQ added a comment. In D65575#1621425 , @Szelethus wrote: > I think it isn't crucial of getting rid of the "The" prefix, if we append ", > which participates in a condition later" (which sounds so much better than > what I added in this patch), so

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus added a comment. In D65575#1625741 , @NoQ wrote: > In D65575#1625738 , @Szelethus wrote: > > > A little early, gentle ping :) I'm getting kinda paranoid with the size of > > the stack, and how much I

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

NoQ added a comment. In D65575#1625738 , @Szelethus wrote: > A little early, gentle ping :) I'm getting kinda paranoid with the size of > the stack, and how much I struggled with commiting last time. Mmm, what are your thoughts on my suggestions with

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus added a comment. A little early, gentle ping :) I'm getting kinda paranoid with the size of the stack, and how much I struggled with commiting last time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

xazax.hun added a comment. Yeah, this is important bike-shedding from the user point of view. Otherwise it looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus added a comment. In D65575#1611013 , @NoQ wrote: > Fantastic! Let's open the wording bikeshed season? > > I suspect that a simple "(The) Value -> Condition value" change would have > worked better. > > Another variant: "Value ..., which

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

NoQ added a comment. Fantastic! Let's open the wording bikeshed season? I suspect that a simple "(The) Value -> Condition value" change would have worked better. Another variant: "Value ..., which participates in a condition later". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, Charusso, baloghadamsoftware, dcoughlin, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Can't add much