[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

2019-08-01 Thread Csaba Dabis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL367608: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its… (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

2019-08-01 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. Thanks for the review and for the idea! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65587/new/ https://reviews.llvm.org/D65587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

2019-08-01 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a subscriber: george.karpenkov. Charusso added inline comments. Comment at: clang/test/Analysis/loop-unrolling.cpp:349-353 #ifdef DFS -clang_analyzer_numTimesReached(); // expected-warning {{10}} +clang_analyzer_numTimesReached(); // expected-warning {{16}

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

2019-08-01 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 212895. Charusso marked an inline comment as done. Charusso edited the summary of this revision. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65587/new/ https://reviews.llvm.org/D65587 Files: clang/include/clang

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

2019-08-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ah, omission of the century :/ Thanks, this looks immediately good! Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:305 + // The 'NodeBuilderContext::blockCount(

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

2019-08-01 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:486 const StackFrameContext *getStackFrame(AnalysisDeclContext *Ctx, - LocationContext const *Paren

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

2019-08-01 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, szepet, baloghadamsoftware, xazax.hun. With this addition we can distinguish between `StackSpa