[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368152: [clang] Fix mismatched args constructing AddressSpaceAttr. (authored by AntonBikineev, committed by ). Herald

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev added a comment. Pinging for review.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev updated this revision to Diff 212882. AntonBikineev added a comment. Roman, -ast-dump shows the correct result, because the correct address space is encoded in qualifiers and is passed to Context.getAddrSpaceQualType(...) later in this function. This is why this bug is not

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

lebedev.ri added a comment. This really needs a test, likely an astdump-one will show it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, klimek. AntonBikineev added a project: clang. Interestingly enough, but this wasn't caught in tests. I wonder if it's possible to write a test case for it. Repository: rC Clang https://reviews.llvm.org/D65589