[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

MaskRay commandeered this revision. MaskRay edited reviewers, added: Romain-Geissler-1A; removed: MaskRay. MaskRay added a comment. This revision is now accepted and ready to land. Herald added subscribers: jansvoboda11, dang. Implemented by 2820a2ca3a0e69c3f301845420e00672251b

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D72724, closing. Thanks @Romain-Geissler-1A for triggering that patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65616/new/ https://reviews.llvm.org/D65616

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

MaskRay added a comment. In D65616#1819581 , @serge-sans-paille wrote: > (back on that one) The default in clang is implicitly > `-fno-semantic-interposition`. I think we can safely support it, and either > warn or error on `-fsemantic-interposition`.

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille added a comment. (back on that one) The default in clang is implicitly `-fno-semantic-interposition`. I think we can safely support it, and either warn or error on `-fsemantic-interposition`. @hfinkel does that seem correct to you? Repository: rG LLVM Github Monorepo

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

Romain-Geissler-1A added a comment. Hi, The only group I know which uses -fsemantic-interposition is the company I work for: Amadeus. Since for now the flag doesn't exist on clang, no we don't know that the future clang implementation doesn't match the gcc one ;) But then we have to wonder if

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

MaskRay added a comment. In D65616#1634966 , @serge-sans-paille wrote: > Adding @hfinkel to the thread to confirm it's okay to add this behavior, as > he authored an RFC on the subject (see >

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille added a reviewer: hfinkel. serge-sans-paille added a subscriber: hfinkel. serge-sans-paille added a comment. Adding @hfinkel to the thread to confirm it's okay to add this behavior, as he authored an RFC on the subject (see

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

Romain-Geissler-1A added a comment. Hi, Thanks Serge. Given that I am only a very occasional contributor, I don't have any right to push this commit myself. Would you please commit it for me ? Thanks, Romain Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65616/new/ https://reviews.llvm.org/D65616

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

Romain-Geissler-1A created this revision. Romain-Geissler-1A added reviewers: serge-sans-paille, chandlerc. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, This simple patch ignores -fsemantic-interposition/-fno-semantic-interposition that may be used by some gcc