This revision was automatically updated to reflect the committed changes.
Closed by commit rL368495: cfi-icall: Allow the jump table to be optionally
made non-canonical. (authored by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D65629?vs=214434&id=214468#toc
Repositor
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65629/new/
https://reviews.llvm.org/D65629
_
pcc updated this revision to Diff 214434.
pcc marked 2 inline comments as done.
pcc added a comment.
- Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65629/new/
https://reviews.llvm.org/D65629
Files:
clang/docs/ControlFlow
pcc marked 6 inline comments as done.
pcc added inline comments.
Comment at: clang/test/CodeGen/cfi-icall-canonical-jump-tables.c:15
+// CHECK: define void @g({{.*}} [[ATTR2:#[0-9]+]]
+__attribute__((cfi_jump_table_canonical)) void g() {}
+
eugenis wrote:
> would
eugenis added inline comments.
Comment at: clang/test/CodeGen/cfi-icall-canonical-jump-tables.c:15
+// CHECK: define void @g({{.*}} [[ATTR2:#[0-9]+]]
+__attribute__((cfi_jump_table_canonical)) void g() {}
+
would it be more natural to spell it "cfi_canonical_jump
pcc added a reviewer: eugenis.
pcc added a comment.
Thanks for the confirmation Kees.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65629/new/
https://reviews.llvm.org/D65629
___
cfe-commits mailing li
kees added a comment.
Just FYI, I can confirm a happily running arm64 kernel with CFI enabled built
with this patch series. The C wrappers aren't needed and CFI is still
triggering on mismatches:
[ 106.656280] lkdtm: Performing direct entry CFI_FORWARD_PROTO
[ 106.657307] lkdtm: Calling m
pcc created this revision.
pcc added reviewers: hctim, tejohnson.
Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya,
mehdi_amini.
Herald added projects: clang, LLVM.
The default behavior of Clang's indirect function call checker will replace
the address of each CFI-checked f
