[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL371494: [RISCV] Default to ilp32d/lp64d in RISC-V Linux (authored by rogfer01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 added a comment. Thanks for the review @lenary @luismarques We can indeed look at what defaults we want for baremetal in a later change. I plan to commit this shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65634/new/ https://reviews.llvm.org/D65634

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Herald added a subscriber: pzheng. I think my feeling is that this patch can land and we can change the default abi for baremetal targets in a follow-up patch. Comment at:

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

luismarques added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:386 + else +return Triple.getArch() == llvm::Triple::riscv32 ? "ilp32" : "lp64"; } luismarques wrote: > When I compile a bare metal GNU toolchain (using >

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

luismarques added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:386 + else +return Triple.getArch() == llvm::Triple::riscv32 ? "ilp32" : "lp64"; } When I compile a bare metal GNU toolchain (using

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 added a comment. Thanks for the clarification @asb. I've posted D66003 (depending on D66002 ) for that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65634/new/ https://reviews.llvm.org/D65634

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

asb added a comment. In D65634#1618443 , @rogfer01 wrote: > Thanks @asb @lenary for the review! > > I understand that, after this change, we will also want to make > `-march=rv{32,64}gc` the default in Linux as well. Otherwise there will be an > ABI

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 updated this revision to Diff 213812. rogfer01 retitled this revision from "[RISCV] Default to lp64d in 64-bit RISC-V Linux" to "[RISCV] Default to ilp32d/lp64d in RISC-V Linux". rogfer01 edited the summary of this revision. rogfer01 added a comment. ChangeLog: - Make `ilp32d` also the

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 added a comment. Thanks @asb @lenary for the review! I understand that, after this change, we will also want to make `-march=rv{32,64}gc` the default in Linux as well. Otherwise there will be an ABI mismatch with the default `-march=rv{32.64}i` in a default invocation. Does this make