[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

This revision was automatically updated to reflect the committed changes. Closed by commit rL369043: [Sema] Implement DR2386 for C++17 structured binding (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with minor adjustments to the test. Comment at: clang/test/CXX/drs/dr23xx.cpp:43-57 +#if __cplusplus >= 201707L +// Otherwise, if the qualified-id std::tuple_size names

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk updated this revision to Diff 215442. rnk added a comment. - add DR test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl.decl/dcl.decomp

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk marked an inline comment as done. rnk added a comment. In D66040#1631658 , @thakis wrote: > rnk, what's the status here? I think I can get this in today, things just got busy here and I forgot about this. I have to add that test.

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

thakis added a comment. rnk, what's the status here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

Jeroen added a comment. In the reproduction of https://bugs.llvm.org/show_bug.cgi?id=33236 there is explicit mentioning of `const T`. It would be nice if the test cases for this fix would also have coverage for that. Comment at: clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp:15 t

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rsmith added a comment. Looks good. Can you add a test to `test/CXX/drs/dr23xx.cpp` with a suitable `dr2386: 10` comment to track that we've implemented DR2386 in Clang 10, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://r

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk created this revision. rnk added a reviewer: rsmith. Herald added a project: clang. Allow implementations to provide complete definitions of std::tuple_size, but to omit the 'value' member to signal that T is not tuple-like. The Microsoft standard library implements std::tuple_size this way.