[PATCH] D66353: [clang-doc] Redesign of generated HTML files

2019-08-16 Thread Diego Astiazarán via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369139: [clang-doc] Redesign of generated HTML files (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

2019-08-16 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 ___ cfe-commits mailing list

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

2019-08-16 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 215642. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Add comments. Fix clang-doc version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 Files:

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

2019-08-16 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:487-489 +static std::unique_ptr +genFileMainNode(StringRef InfoPath, +std::vector> , Would you be able to briefly comment on each of these `gen*Node`

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

2019-08-16 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 215624. DiegoAstiazaran added a comment. Run clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp