[PATCH] D66404: [CFG] Make destructor calls more accurate

nathanchance added a comment. @NoQ thank you for the fix, I can confirm it works! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66404/new/ https://reviews.llvm.org/D66404 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D66404: [CFG] Make destructor calls more accurate

NoQ added a comment. Thanks @nathanchance! I think i fixed it in rC370406 . Comment at: cfe/trunk/lib/Analysis/CFG.cpp:2983-2984 - // Add the return statement to the block. This may create new blocks if R - // contains control-flow (shor

[PATCH] D66404: [CFG] Make destructor calls more accurate

nathanchance added a comment. This commit causes some warnings in the Linux kernel that appear to be false positives. For example: CC drivers/base/cpu.o drivers/base/cpu.c:404:1: error: control may reach end of non-void function [-Werror,-Wreturn-type] } ^ 1 error generated. C

[PATCH] D66404: [CFG] Make destructor calls more accurate

This revision was automatically updated to reflect the committed changes. Closed by commit rL370247: [CFG] Make representation of destructor calls more accurate. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66404: [CFG] Make destructor calls more accurate

Szelethus added a comment. In D66404#1645851 , @comex wrote: > Heh, I guess I'll request commit access, although I'm not sure if I have > enough of a 'track record of submitting high quality patches'. You really do :) Repository: rC Clang CHANGES S

[PATCH] D66404: [CFG] Make destructor calls more accurate

comex added a comment. Heh, I guess I'll request commit access, although I'm not sure if I have enough of a 'track record of submitting high quality patches'. But for now, can you commit this? Thanks :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66404/new/

[PATCH] D66404: [CFG] Make destructor calls more accurate

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks fantastic, thanks! > Note: I don't have commit access. I can commit this for you but i believe you should totally ask for it

[PATCH] D66404: [CFG] Make destructor calls more accurate

comex updated this revision to Diff 216545. comex marked 9 inline comments as done. comex added a comment. Changes since last version: - Rebased. - Added `ExternallyDestructed` parameter to `VisitExprWithCleanups` and `CFGBuilder::Visit`; removed `VisitExternallyDestructed`. - Changed CFG printi

[PATCH] D66404: [CFG] Make destructor calls more accurate

comex abandoned this revision. comex marked 18 inline comments as done. comex added inline comments. Comment at: lib/Analysis/CFG.cpp:2102 case Stmt::CompoundStmtClass: - return VisitCompoundStmt(cast(S)); + return VisitCompoundStmt(cast(S), /*ExternallyDestructed

[PATCH] D66404: [CFG] Make destructor calls more accurate

NoQ added a comment. I have a few nitpicks but i still love this patch, thank you! It picks up the work exactly where i dropped it a year or so ago. > Respect C++17 copy elision; previously it would generate destructor calls for > elided temporaries, including in initialization and return state

[PATCH] D66404: [CFG] Make destructor calls more accurate

NoQ added a comment. Whoaaa, at a glance this looks absolutely fantastic. I'll get back to this tomorrow to take a more careful look. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66404/new/ https://reviews.llvm.org/D66404

[PATCH] D66404: [CFG] Make destructor calls more accurate

comex created this revision. comex added reviewers: dergachev.a, Szelethus, dcoughlin. Herald added a project: clang. Herald added a subscriber: cfe-commits. Note: I don't have commit access. Various changes to reduce discrepancies in destructor calls between the generated CFG and the actual code