This revision was automatically updated to reflect the committed changes.
Closed by commit rL371967: [SVE][Inline-Asm] Add constraints for SVE predicate
registers (authored by kmclaughlin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D66524?vs=219526=220299#toc
rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.
I think all the outstanding comments have been addressed. LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66524/new/
https://reviews.llvm.org/D66524
kmclaughlin marked 3 inline comments as done.
kmclaughlin added inline comments.
Comment at: docs/LangRef.rst:3818
+- ``Upl``: One of the low eight SVE predicate registers (P0 to P7)
+- ``Upa``: Any of the SVE predicate registers (P0 to P15)
greened wrote:
>
kmclaughlin updated this revision to Diff 219526.
kmclaughlin added a comment.
- Renamed the //isPredicateConstraint// function to //parsePredicateConstraint//
- Added more thorough checks to the tests in aarch64-sve-asm.ll
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66524/new/
greened added inline comments.
Comment at: docs/LangRef.rst:3818
+- ``Upl``: One of the low eight SVE predicate registers (P0 to P7)
+- ``Upa``: Any of the SVE predicate registers (P0 to P15)
What do these names mean? " predicate lower|all?" I see they are
rovka added a comment.
Just some drive-by suggestions :)
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5747
+
+PredicateConstraint isPredicateConstraint(StringRef Constraint) {
+ PredicateConstraint P = PredicateConstraint::Invalid;
Nit: I think get-
kmclaughlin updated this revision to Diff 218071.
kmclaughlin added a comment.
- Added isPredicateConstraint function to AArch64ISelLowering.cpp, which
returns Upl, Upa or Invalid. This is used to replace some repeated checks of
the predicate type
- Minor changes to InlineAsm.cpp
CHANGES
sdesmalen added inline comments.
Comment at: lib/IR/InlineAsm.cpp:188
+ unsigned char C = static_cast(*I);
+ assert(isdigit(C) && "Not a single digit!");
+ int N = C - '0';
`"Expected a digit"` seems more appropriate, since this code is only
kmclaughlin created this revision.
kmclaughlin added reviewers: t.p.northover, sdesmalen, rovka, momchil.velikov,
cameron.mcinally, greened.
Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
kmclaughlin added a
