gribozavr added inline comments.
Comment at: clang/tools/libclang/Indexing.cpp:134
void copyTo(PPRegionSetTy &Set) {
std::lock_guard MG(Mux);
Set = ParsedRegions;
jkorous wrote:
> gribozavr wrote:
> > I think we should lock both the source and destin
jkorous marked 3 inline comments as done.
jkorous added inline comments.
Comment at: clang/tools/libclang/Indexing.cpp:371
- SessionSkipBodyData *SKData;
- std::unique_ptr SKCtrl;
+ SharedParsedRegionsStorage *SKData;
+ std::unique_ptr ParsedLocsTracker;
jk
jkorous marked 4 inline comments as done.
jkorous added a comment.
Hmm, I already landed this - let's transfer the discussion to
https://reviews.llvm.org/D66764.
I'll make the changes to that patch. Is that ok?
Comment at: clang/tools/libclang/Indexing.cpp:126
+/// Is thread-s
gribozavr added inline comments.
Comment at: clang/tools/libclang/Indexing.cpp:126
+/// Is thread-safe.
+class SharedParsedRegionsStorage {
std::mutex Mux;
"SharedParsedRegions"? "ThreadSafeParsedRegions"?
Comment at: clang/tools/libclang/In
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb1c90791024b: [libclang][index][NFCi] Refactor machinery for
skipping function bodies (authored by jkorous).
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Gi
