[PATCH] D66711: [clang] Warning for non-final classes with final destructors

xbolva00 added a comment. rL370737 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

thakis added a comment. This is a cool warning. Could the note have a fixit attached to it, so that it's easy to mass-clean-up the warning automatically? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 _

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rL370594: [clang] Warning for non-final classes with final destructors (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

logan-5 marked an inline comment as done. logan-5 added a comment. Thanks. I'll need someone with commit access to help me out with this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 _

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

yamauchi accepted this revision. yamauchi added a comment. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

logan-5 updated this revision to Diff 217049. logan-5 added a comment. Addressed some feedback. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2204 "abstract class is marked '%select{final|sealed}0'">, InGroup; +def warn_final_destructor_nonfinal_class : Warning< + "class with destructor marked '%select{final|sealed}0' c

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Looks fine Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 ___ cfe-

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

logan-5 created this revision. logan-5 added reviewers: rsmith, yamauchi. logan-5 added a project: clang. Herald added a subscriber: cfe-commits. Marking a class' destructor `final` prevents the class from being inherited from. However, it is a subtle and awkward way to express that at best, and