[PATCH] D66713: ContentCache: Drop getBuffer's dependency on SourceManager

2019-08-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith closed this revision. dexonsmith added a comment. Committed in r369958. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66713/new/ https://reviews.llvm.org/D66713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D66713: ContentCache: Drop getBuffer's dependency on SourceManager

2019-08-26 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66713/new/ https://reviews.llvm.org/D66713 ___ cfe-commits mailing list cfe-commi

[PATCH] D66713: ContentCache: Drop getBuffer's dependency on SourceManager

2019-08-24 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 217036. dexonsmith added a comment. (Updating the diff with full context.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66713/new/ https://reviews.llvm.org/D66713 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic/SourceManage

[PATCH] D66713: ContentCache: Drop getBuffer's dependency on SourceManager

2019-08-24 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: arphaman, bruno. Herald added a subscriber: ributzka. Refactor ContentCache::IsSystemFile to IsFileVolatile, checking SourceManager::userFilesAreVolatile at construction time. This is a step toward lowering ContentCache down from Sourc