[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

This revision was automatically updated to reflect the committed changes. Closed by commit rL370033: [Driver] Add an option for createInvocationFromCommandLine to recover on errors (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:150 /// + /// If an error was encountered while parsing the arguments, \returns false + /// and attempts to recover and continue parsing the rest of the arguments.

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov updated this revision to Diff 217335. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Start a paragrah with \returns instead of putting it in the middle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D667

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:150 /// + /// If an error was encountered while parsing the arguments, \returns false + /// and a

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov updated this revision to Diff 217320. ilya-biryukov added a comment. - Fix english grammar in the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66731/new/ https://reviews.llvm.org/D66731 Files: clang-tools-extra/clangd/Comp

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov updated this revision to Diff 217319. ilya-biryukov added a comment. - Add a comment to CreateFromArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66731/new/ https://reviews.llvm.org/D66731 Files: clang-tools-extra/clangd/Compile

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov added a comment. In D66731#1644840 , @gribozavr wrote: > - In the doc comment for `CompilerInvocation::CreateFromArgs`, could you add > a note that it does a best effort to provide a CompilerInvocation even if it > returns false? Right no

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

gribozavr added a comment. It does seem reasonable for Clangd to recover when it sees unknown command line flags (after all, in compiler_commands.json we can see command line flags from past and future versions of Clang, GCC and other compilers -- whatever the build system decided to write ther

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: kadircet, arphaman, jkorous. Herald added a project: clang. Previously, it would always return nullptr on any error. This change adds a parameter, controlling whether the function should attem