This revision was automatically updated to reflect the committed changes.
jvikstrom marked 4 inline comments as done.
Closed by commit rG1c9aa70b042b: [clangd] Handling text editor/document
lifetimes in vscode extension. (authored by jvikstrom).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
I think there is one more case -- we need to cleanup the highlighting cache if
clangd crashes, the extension will automatically restart clangd up to 5 times
if it sees clangd crashes, you can
jvikstrom updated this revision to Diff 217134.
jvikstrom added a comment.
Fixed changes that weren't supposed to be made.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66735/new/
https://reviews.llvm.org/D66735
Files:
clang-tools-extra/clangd/c
jvikstrom updated this revision to Diff 217131.
jvikstrom added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66735/new/
https://reviews.llvm.org/D66735
Files:
clang-tools-extra/clangd/clients/clangd-vscode/src/seman
hokein added inline comments.
Comment at:
clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:94
+vscode.window.onDidChangeVisibleTextEditors(
+() => this.highlighter.onDidChangeVisibleTextEditors());
+vscode.workspace.onDidCloseTextDocume
jvikstrom marked an inline comment as done.
jvikstrom added inline comments.
Comment at:
clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:94
+vscode.window.onDidChangeVisibleTextEditors(
+() => this.highlighter.onDidChangeVisibleTextEditors
hokein added inline comments.
Comment at:
clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:94
+vscode.window.onDidChangeVisibleTextEditors(
+() => this.highlighter.onDidChangeVisibleTextEditors());
+vscode.workspace.onDidCloseTextDocume
jvikstrom created this revision.
jvikstrom added reviewers: hokein, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Just reapplies highlightings for all files when visible text editors change.
Could find the correct text e
