This revision was automatically updated to reflect the committed changes.
Closed by commit rL370039: Refactor GlobList from an ad-hoc linked list to a
vector (authored by gribozavr, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
h
gribozavr marked an inline comment as done.
gribozavr added inline comments.
Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:46
+GlobList::GlobList(StringRef Globs) {
+ do {
+GlobListItem Item;
ilya-biryukov wrote:
> NIT: I suggest using `for (;!Globs.
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:46
+GlobList::GlobList(StringRef Globs) {
+ do {
+GlobListItem Item;
NIT: I sug
gribozavr created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I think it makes method implementations more obvious.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D66788
Files:
clang-tools-extra/clang-tidy/GlobList.cpp
clang-tools-e
