[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

This revision was automatically updated to reflect the committed changes. Closed by commit rL370451: [Tooling] Migrated APIs that take ownership of objects to unique_ptr (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

gribozavr added a comment. In D66960#1651258 , @lebedev.ri wrote: > In D66960#1651243 , @gribozavr wrote: > > > In D66960#1651198 , @lebedev.ri > > wrote: > > > > > This is

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

gribozavr updated this revision to Diff 218046. gribozavr added a comment. Updated documentation and added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66960/new/ https://reviews.llvm.org/D66960 Files: clang-tools-extra/clangd/un

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM from my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66960/new/ https://reviews.llvm.org/D66960 ___

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

lebedev.ri added a comment. In D66960#1651243 , @gribozavr wrote: > In D66960#1651198 , @lebedev.ri > wrote: > > > This is missing documentation changes. > > > Could you point out such places? I tried to remove "ta

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

gribozavr added a comment. In D66960#1651198 , @lebedev.ri wrote: > This is missing documentation changes. Could you point out such places? I tried to remove "takes ownership" comments which became redundant. > And this likely would be good to mention

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

lebedev.ri added a comment. This is missing documentation changes. And this likely would be good to mention in releasenotes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66960/new/ https://reviews.llvm.org/D66960 ___

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66960 Files: clang-tools-extra/clangd/unittests/IndexActionTests.cpp clang-tools-extra/unittests