This revision was automatically updated to reflect the committed changes.
Closed by commit rL371038: [clangd][vscode] Add a flag to enable semantic
highlighting in clangd (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67096/new/
https://reviews.llvm.org/D67096
hokein added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new semanticHighlighting.SemanticHighlightingFeature(
+
hokein updated this revision to Diff 218864.
hokein marked 2 inline comments as done.
hokein added a comment.
rebase and simplify the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67096/new/
https://reviews.llvm.org/D67096
Files:
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new semanticHighlighting.SemanticHighlightingFeature(
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new semanticHighlighting.SemanticHighlightingFeature(
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new semanticHighlighting.SemanticHighlightingFeature(
hokein updated this revision to Diff 218452.
hokein marked 2 inline comments as done.
hokein added a comment.
address the comment, don't register the feature.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67096/new/
https://reviews.llvm.org/D67096
hokein added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new semanticHighlighting.SemanticHighlightingFeature(
+
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113
const semanticHighlightingFeature =
- new semanticHighlighting.SemanticHighlightingFeature();
+ new semanticHighlighting.SemanticHighlightingFeature(
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D67096
Files:
14 matches
Mail list logo