ymandel marked 3 inline comments as done.
ymandel added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/bugprone-use-after-move.cpp:1198
+}
+ }
for (int i = 0; i < 10; ++i) {
mboehme wrote:
> gribozavr wrote:
> > ymandel wrote:
> > > griboz
This revision was automatically updated to reflect the committed changes.
ymandel marked an inline comment as done.
Closed by commit rL371396: [clang-tidy] Fix bug in bugprone-use-after-move
check (authored by ymandel, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-c
mboehme added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/bugprone-use-after-move.cpp:1198
+}
+ }
for (int i = 0; i < 10; ++i) {
gribozavr wrote:
> ymandel wrote:
> > gribozavr wrote:
> > > Unless you think it is redundant, could you al
gribozavr added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/bugprone-use-after-move.cpp:1198
+}
+ }
for (int i = 0; i < 10; ++i) {
ymandel wrote:
> gribozavr wrote:
> > Unless you think it is redundant, could you also add
> >
> > ```
>
ymandel marked 2 inline comments as done.
ymandel added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/bugprone-use-after-move.cpp:1198
+}
+ }
for (int i = 0; i < 10; ++i) {
gribozavr wrote:
> Unless you think it is redundant, could you al
ymandel updated this revision to Diff 219152.
ymandel added a comment.
Added tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67292/new/
https://reviews.llvm.org/D67292
Files:
clang-tools-extra/clang-tidy/utils/ExprSequence.cpp
clang-tools
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
Thanks for the quick fix!
Comment at: clang-tools-extra/test/clang-tidy/bugprone-use-after-move.cpp:1198
+}
+ }
for (int i = 0; i < 10; ++i) {
ymandel created this revision.
ymandel added a reviewer: gribozavr.
Herald added a subscriber: xazax.hun.
Herald added a project: clang.
The bugprone-use-after-move check exhibits false positives for certain uses of
the C++17 if/switch init statements. These false positives are caused by a bug
in
