[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. The follow-up patch, implementing this correctly, is D70116 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

hans added a comment. I've reverted in b1ac1f00716 until it can be fixed properly. We noticed this in Chromium where we started seeing build spam like: '+soft-float-abi' is not a recognized feature for this target (ignoring

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:498 +CmdArgs.push_back( +Args.MakeArgString(Twine("-plugin-opt=-target-abi=") + ABIName)); } khchen wrote: > efriedma wrote: > > I don't think this change is right

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen marked an inline comment as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:498 +CmdArgs.push_back( +Args.MakeArgString(Twine("-plugin-opt=-target-abi=") + ABIName)); } efriedma wrote: > I don't think

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

efriedma added inline comments. Herald added a subscriber: sameer.abuasal. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:498 +CmdArgs.push_back( +Args.MakeArgString(Twine("-plugin-opt=-target-abi=") + ABIName)); } I don't think this change i

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. @khchen Thanks for your patch! It is now landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 ___ cfe-commits mailing list cfe-commit

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdcf58e5af02: [RISCV] enable LTO support, pass some options to linker. (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https:

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen added a comment. In D67409#1707940 , @lenary wrote: > @khchen do you need me to commit this for you? Yes, please help me, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 __

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. @khchen do you need me to commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 224821. khchen added a comment. rebase master, https://reviews.llvm.org/D66003 changed the `riscv::getRISCVTargetFeatures` interface. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 Files: clang/lib/Drive

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Herald added a subscriber: hiraditya. Nice, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 __

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 220668. khchen added a comment. Thanks @lenary, I fixed it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. I have some nits about explicit comments for arguments and default argument values for backwards compatibility. Other than that, it looks like a nice code cleanup. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6071 // Add the target features -

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 220214. khchen edited the summary of this revision. khchen added a comment. Herald added subscribers: fedor.sergeev, aheejin, dschuff. This commit is inspired by @MaskRay's suggestion, I think maybe fix the insufficient of clang::driver:tools::AddGoldPlugin is

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:414 + +CmdArgs.push_back(Args.MakeArgString(Twine("-plugin-opt=--" + "mattr=") + The single-dash form of `mattr`: `-plugin-opt=

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain &ToolChain, + const llvm::opt::ArgList &Args, kito-cheng wrote: > MaskRay wrote: > > gold doesn't supp

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain &ToolChain, + const llvm::opt::ArgList &Args, MaskRay wrote: > gold doesn't support RISC-V, does i

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain &ToolChain, + const llvm::opt::ArgList &Args, gold doesn't support RISC-V, does it? CHANGES SINCE L

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 219941. khchen added a comment. @lenary Yes, you are right. add LTO support for Linux platform. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/lib/

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. Can you add a test for `riscv64-unknown-linux-gnu`? I think RISCVToolchain.cpp is only used by the `riscv64-unknown-elf` target, but I could be wrong. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D6740

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen created this revision. khchen added a project: clang. Herald added subscribers: pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, dexonsmith, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, s