[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

thakis added a comment. Yup, test is happy now, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

tejohnson added a comment. In D67592#1688413 , @thakis wrote: > This is failing on my mac like so: This should be fixed by r373237. I didn't get any email with buildbot failures, but someone mailed one to me manually. Not sure why it only fails

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

thakis added a comment. This is failing on my mac like so: FAIL: Clang :: Frontend/stdin-input.c (1 of 1) TEST 'Clang :: Frontend/stdin-input.c' FAILED Script: -- : 'RUN: at line 1'; cat

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

This revision was automatically updated to reflect the committed changes. Closed by commit rL373217: [Clang] Use -main-file-name for source filename if not set (authored by tejohnson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

the_jk added a comment. Great, thanks again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

tejohnson added a comment. In D67592#1686898 , @the_jk wrote: > I don't have commit access so I'd need someone to push this, thanks. I can commit for you today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

the_jk added a comment. I don't have commit access so I'd need someone to push this, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 ___ cfe-commits mailing list

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

the_jk updated this revision to Diff 51. the_jk added a comment. Moved ModuleName change to CodeGeneratorImpl as suggested, agree that it seems to fit well there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 Files:

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

tejohnson added a comment. Please upload patches with context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) I'm not terribly familiar with this part of clang, but my concern would be that overriding the PresumedInputFile here could have unintended side

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

the_jk added a comment. Forgot to link: https://bugs.llvm.org/show_bug.cgi?id=43250 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 ___ cfe-commits mailing

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

the_jk created this revision. the_jk added a reviewer: rsmith. the_jk added a project: clang. Herald added subscribers: cfe-commits, aprantl. -main-file-name is currently used to set the source name used in debug information. If the source filename is "-" and -main-file-name is set, then use