This revision was automatically updated to reflect the committed changes.
Closed by commit rL372410: [libTooling] Add `ifBound`, `elseBranch`
RangeSelector combinators. (authored by ymandel, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to co
ymandel updated this revision to Diff 221052.
ymandel added a comment.
reordered tests to match as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67621/new/
https://reviews.llvm.org/D67621
Files:
clang/include/clang/Tooling/Refactoring/Rang
ymandel added inline comments.
Comment at: clang/lib/Tooling/Refactoring/RangeSelector.cpp:320
+ };
+}
gribozavr wrote:
> May I ask to keep the implementation order consistent with the header file?
Moved the decl in the header to match the ordering in the implem
ymandel updated this revision to Diff 221050.
ymandel marked 2 inline comments as done.
ymandel added a comment.
reordered decls
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67621/new/
https://reviews.llvm.org/D67621
Files:
clang/include/clang/
gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Tooling/Refactoring/RangeSelector.cpp:320
+ };
+}
May I ask to keep the implementation order consistent with the header file
ymandel created this revision.
ymandel added a reviewer: gribozavr.
Herald added a project: clang.
Adds two new combinators and corresponding tests to the RangeSelector library.
- `ifBound` -- conditional evaluation of range-selectors, based on whether a
given node id is bound in the match.
- `e
