[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

This revision was automatically updated to reflect the committed changes. Closed by commit rL372497: Clang-format: Add Whitesmiths indentation style (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

timwoj added a comment. I don't have push access for `master`. Can someone merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 ___ cfe-commits mailing

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 ___ cfe-commits mailing list

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

timwoj updated this revision to Diff 220610. timwoj added a comment. Marked failing tests as FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

krasimir added a comment. Adding @djasper as this is really a re-implementation of https://reviews.llvm.org/D6833. Agree with @MyDeveloperDay that in general we should aim to document all the known cases where a style doesn't work (with FIXMEs etc.), but not submit failing tests. We can have

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay added a comment. when/if you commit can you abandon D6833: Clang-format: Braces Indent Style Whitesmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay added a comment. Thank you for this patch This LGTM, ensure you comment out the failing unit tests and add a FIXME to the test as to why they don't currently work (or fix them if possible), the tests need to keep passing or others will not know they haven't broken things.

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

mboehme added a comment. In D67627#1671638 , @echristo wrote: > Martin should know who should look at this... maybe Krasimir? Yes, I think he'd be a good person to look at this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

echristo added reviewers: mboehme, krasimir. echristo added a comment. Martin should know who should look at this... maybe Krasimir? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

timwoj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for the Whitesmiths indentation style to clang-format. It’s an update to a patch submitted in 2015 (D6833 ), but reworks it to use the