[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Jiboo abandoned this revision. Jiboo added a comment. Superseded by D68172 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

aaronpuchert added a comment. In D67877#1686961 , @Jiboo wrote: > @Szelethus could you confirm that thus examples shouldn't be built when > CLANG_BUILD_EXAMPLES is OFF, and that this patch is still valid? The problem is that `CLANG_BUILD_EXAMPLES` is

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Jiboo added a comment. @aaronpuchert thanks, that looks like a better fix than mine for PR43430, although I'm not sure D68172 obsoletes this patch. @Szelethus could you confirm that thus examples shouldn't be built when CLANG_BUILD_EXAMPLES is OFF, and that

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

aaronpuchert added a comment. I didn't know about this patch and published D68172 : adding `BUILDTREE_ONLY` still builds the examples, but doesn't install them. It's also used by other test plugins like `llvm/lib/Transforms/Hello`. Thanks to @lebedev.ri for

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Szelethus added a comment. I have no objections on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877 ___ cfe-commits mailing list

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Jiboo added a comment. Here you go: https://bugs.llvm.org/show_bug.cgi?id=43430 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877 ___ cfe-commits mailing list

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

lebedev.ri added a subscriber: tstellar. lebedev.ri added a comment. Actually, uh oh. @Jiboo can you please file this as a bug? This really should go into next patch release. CC @tstellar @Szelethus this breaks LLVMExports.cmake as compared with LLVM-8, so it's actually a critical bug.

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Jiboo added a comment. @Szelethus take your time, I'm surprised to be the first with the problem (couldn't find reference on google or llvm bug tracker), I wouldn't be surprised if I fucked up somewhere and that this patch isn't really necessary. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Szelethus added a comment. Apologies for the intrusion, but these plugins were added by me, and test an important case for our internal plugins. Could you please give me just a day or so the check whether the tests work for us correctly? Repository: rC Clang CHANGES SINCE LAST ACTION